-
Notifications
You must be signed in to change notification settings - Fork 114
[example] Add example for Swift Service Lifecycle #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…-lambda-runtime into sebsto/servicelifecycle
2432ed3
to
018d9ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a comprehensive example demonstrating Swift Service Lifecycle integration with AWS Lambda and PostgreSQL RDS, along with minor fixes to Docker command references and local server implementation.
- Adds a complete ServiceLifecycle+Postgres example with AWS infrastructure setup
- Fixes Docker command references in format checking scripts
- Updates local server implementation to handle return values properly
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
scripts/check-format-linux.sh | Fixed Docker command references from 'container' to 'docker' |
Sources/AWSLambdaRuntime/Lambda+LocalServer.swift | Updated return type handling and error management in local server |
Examples/Streaming/samconfig.toml | Added SAM configuration for streaming example |
Examples/ServiceLifecycle+Postgres/* | Complete new example with PostgreSQL integration, infrastructure templates, and documentation |
.licenseignore | Added .toml files to license ignore list |
.github/workflows/pull_request.yml | Added new example to CI workflow |
@adam-fowler This is a new example. The rest is "just" a PostgreSQL + service lifecycle example. I provide a SAM template to setup the database in a secure way (private network, restrictive security groups, password stored in secret manager) |
Now that task cancellation works, re publishing this PR with a new example for Swift Service Lifecycle